Add style support on wrapped image #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baptiste-Garcin
commented
Jul 14, 2017
index.js
Outdated
| @@ -148,10 +150,12 @@ export const createImageProgress = ImageComponent => | |||
| renderIndicator, | |||
| source, | |||
| style, | |||
| threshold, | |||
There was a problem hiding this comment.
my eslint told me that treshold was not used anymore so...
Closed
|
PLEASE, accept this PR... |
|
Closed in favor of #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add an imageProps parameter that should contain the style that must be applied to the wrapped image.
The style passed to the image will be combine with StyleSheet.absoluteFillObject (position: 'absolute', top: 0, bottom: 0, right: 0, left: 0).
I also update the ReadMe file.