-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keychain + sharedpreferences support #12
Comments
It's definitely planned, but no ETA right now. A PR would be highly appreciated! On Sat, Oct 10, 2015 at 10:59 AM, Chris Geirman notifications@github.com
|
I think Keystore would be more appropriate? http://developer.android.com/training/articles/keystore.html SharedPreferences isn't encrypted. |
Was having a look at this the other day, may do an implementation with https://facebook.github.io/conceal/ and ship a PR over. |
That looks pretty awesome, @corymsmith |
@geirman I'll probably start digging into this today :) |
@corymsmith 👏 🙇 |
Ran into some conflicts with React Native so had to update Conceal to fix it. Made some great progress today! It looks like there are some issues with Conceal on recent Android versions that are in progress so will have to see how that progresses.! |
@corymsmith are you creating an android version for this ? would like to collaborate - liorsaar1@gmail.com |
@liorsaar1 Yes, I have some updates in the android-support branch of my fork. I was having some issues unencrypting and still working through the best approach for Android. I broke my arm so can't do much until thats all sorted unfortunately |
@corymsmith: 👏 so excited about this! Get well 😷 |
Any updates about the android support ? I'm very excited about it :) |
@paulondc I've been super busy as of late with a few other open source projects and my new consulting company so haven't looked at this in a it but it was super close when I last left off. I'll be needing this in a few apps in the near future so hoping to pick it back up and wrap a release in the next few weeks or less |
Thanks @corymsmith for all effort you are putting on this 👏 I wonder if we could help you somehow, since this is going to introduce the initial support for android, I think we could have a special branch under this repository for this feature, so everybody interested on this could try it, watch the progress, create pull requests, etc.. What do you guys think about it ? |
@paolondc The branch is here: https://github.com/corymsmith/react-native-keychain/tree/android-support |
nice work! @paulondc when can we expect the android support in npm? Thanks! |
Finally 0.3.0 with android support is on npm. Thanks to everyone involved making this happen! |
Hi folks, I was just wondering if there was any particular (security or performance) reason why Android's KeyStore wasn't used |
Hello,
|
wondering if you plan to also include SharedPreferences support for Android. A single component that abstracts both would be awesome.
The text was updated successfully, but these errors were encountered: