[android] return false instead of exception when entry not present #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will return false when a keychain entry is not present, so it'll behave same as on ios
This was referenced Mar 5, 2017
Closed
|
👍 |
|
Released in 1.2.0. |
|
If I read the objective C-code correctly at 0.3.2, this should be clearly listed as a breaking change in the 1.0.0 release. Being #not_an_obj_c_master it took me quite a while to track this down. (We relied on the catch-clause for key without value to look for another key) |
|
This pr was a bug fix and only concerns Android, the ios functionality was not modified. |
|
@VojtechNovak totally correct. But the iOS functionality changed with the 1.0.0 release and this is the only place I've found that talks about this change that I've found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will make it behave same as on ios