-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionicons V5 #1128
Comments
same request here! |
same here, Project doesn't build for me after installing v5 on react native version "0.61.5" |
+1 |
I have the font files here: https://github.com/JacksonLaw/react-native-ionicons/blob/fonts-request/fonts/Ionicons.ttf |
The feedback in this repo sucks tbh ... 😞 |
I left a comment on this duplicate issue: #1145 (comment) Basically, I'd be willing to create a pull request for ionicons v5, but I'm not sure what the update process is. Also, @JacksonLaw I installed |
@humatic same issue here, any update from you guys? |
@dushyanttessact Not in relation to this issue. But I found a work around that I'm reasonably happy with. I ended up downloading the latest SVG files directly from Ionicons and then using SVGR to convert the files to JS. Here's an example of the command to use:
This method is a bit more manual than I would have liked, but on the other hand it removed a dependency from my stack and gave me more control. Note that I still had to make a few minor tweaks directly to the output JS files (ex: missing fill color). |
Thanks for sharing that solution, @humatic. I'm in the situation where I want to use icons from Ionicons 5 but |
In my PR. |
Any update on this? |
+1 |
i created a fresh react native project, somehow the app is crashing because Ionicons are missing?? hmmm
Error: Unrecognized font family 'Ionicons' "react-native-vector-icons": "6.7.0", |
I think your import statement is wrong, it should be |
@arstropica I saw that your PR was merged on 2nd of July and there was v7 release on 4th of July, however it seems that ionicons are still using old style. Do you by any chance know if your changes were released yet? |
@MinimogDev I believe my PR was merged in v6.7.0. |
@arstropica I've installed v7.0.0, and I'm unable to use any of the new IonIcons icons. I've tried cleaning the build folder, and rebuilding pods, but that didn't fix it. The older "ios-" and "android-" icons work fine. @MinimogDev Did you find a solution? |
@RealDyllon I'm afraid not, I'm on v7 as well (fresh project that never used this lib before), but I see old ionicon designs |
@MinimogDev @RealDyllon https://snack.expo.io/@estatesales/c731d8 You can try comparing the glyph code of a working icon with that in glypmaps/Ionicons.json and see if they are the same. The above snack gives a different code suggesting that expo is loading an earlier version. |
@arstropica My . I'm using bare react native, and cocoapods to link the native dependencies. Could this be a .ttf issue? |
@RealDyllon Not sure. Could be a dependency collision. Do you have any dependencies that also load the Ionicons font (i.e. nativebase)? If so, do they load a different version?
|
@arstropica here's npm's response:
Looks like this is the only dependency. Looking through the entire xcode project, I could only find import references to the .ttf in the /fonts directory of the npm module. Any way to check the version of that? "Get info" states the .ttf is v1.00 Or could it be that an older .ttf is still cached somewhere? |
@RealDyllon Possibly. I just tried v.7.0.0 with a new install and the new icons worked fine. I used the Manual Option for setup and coped the list of fonts into info.plist.
If the console statement outputs null or the icon fails to appear, then it's a problem with RN. |
This happened in #1176 |
Please update to Ionicons version 5. There are a lot of new Icons.
The text was updated successfully, but these errors were encountered: