Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override of createJSModules #515

Closed
fractalwrench opened this issue Jul 18, 2017 · 2 comments
Closed

Remove override of createJSModules #515

fractalwrench opened this issue Jul 18, 2017 · 2 comments

Comments

@fractalwrench
Copy link
Contributor

The current release candidate (4) for React Native 0.47 has removed the createJSModules method in ReactPackage. Therefore any overrides of this method will need to be removed from the library, or this will cause a compilation error.

See: facebook/react-native@ce6fb33
@oblador
Copy link
Owner

oblador commented Jul 18, 2017

I'm currently on vacation and will be for two weeks, however if you can supply a PR I could merge and release it :-)

@nabati
Copy link

nabati commented Jul 18, 2017

I agree with @oblador

@fractalwrench fractalwrench mentioned this issue Jul 18, 2017
Merged
oblador pushed a commit that referenced this issue Jul 30, 2017
@fractalwrench @oblador
Remove override of createJSModules (#516)
b7599a0 
* Remove override of createJSModules

Fixes #515

* Update VectorIconsPackage.java

remove override annotation, this allows for backwards compatibility.

* Diff nit

* And another nit..
@xvonabur xvonabur mentioned this issue Aug 10, 2017
Closed
@alexisbg alexisbg mentioned this issue Sep 2, 2017
Closed
@p-tsai p-tsai mentioned this issue Oct 19, 2017
Merged
@adamgajzlerowicz adamgajzlerowicz mentioned this issue Feb 12, 2018
Open
@sewerrat sewerrat mentioned this issue Apr 17, 2018
Closed
esilverberg added a commit to perrystreetsoftware/react-native-rtmpview that referenced this issue Oct 10, 2018
@esilverberg
Remove @OverRide (not used in 0.45)
cf4de0b 
oblador/react-native-vector-icons#515
@SAnegondhi SAnegondhi mentioned this issue Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oblador @nabati @fractalwrench