Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNVectorIcons.podspec #1530

Closed
wants to merge 1 commit into from
Closed

Conversation

billnbell
Copy link

RN 0.72+

@johnf
Copy link
Collaborator

johnf commented Aug 15, 2023

@oblador I'm going to do some testing on this now, but I think we should merge. It is inline with https://reactnative.dev/docs/next/new-architecture-library-ios instructions on supporting New Arch

@johnf
Copy link
Collaborator

johnf commented Aug 15, 2023

I've confirmed it works with the example app with old and new arch

@jhen0409
Copy link

jhen0409 commented Sep 5, 2023

Looks like the method is only available on RN >= 0.71, so this represents a breaking change.

@johnf
Copy link
Collaborator

johnf commented Oct 8, 2023

CLosing in favour of #1550

@johnf johnf closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants