Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getImageSourceSync method, fixes #1315 #1561

Merged

Conversation

mucahittekin
Copy link
Contributor

Added getImageSourceSync method to create-multi-style-icon-set.js file. Fixes: #1315

@oblador
Copy link
Owner

oblador commented Oct 26, 2023

Thanks for your PR! Do you need to make any changes to the types too?

@oblador
Copy link
Owner

oblador commented Oct 26, 2023

Doesn't seem so AFAICT 👍

@oblador oblador merged commit 856dfd9 into oblador:master Oct 26, 2023
1 check passed
@oblador
Copy link
Owner

oblador commented Oct 26, 2023

Released in 10.0.1

@mucahittekin mucahittekin deleted the image-source-sync-for-multi-style-icons branch October 26, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getImageSourceSync is undefined for FontAwesome5
2 participants