Use correct react native packager require paths
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows Facebook's internal pathing for their private modules - and allows other packagers (such as [react-native-webpack-server](https://github.com/mjohnston/react-native-webpack-server)) to properly resolve these guys. See magus/react-native-facebook-login#25 and mjohnston/react-native-webpack-server#87 for some background
|
Not sure this is the way to go since it's been officially discouraged and will throw packager warnings. It works for the moment, but might not in the future. There's an issue about exposing more stuff publicly, let's see where that lands. Actually I've had plans to refactor the styling part to be more explicit but it will be a breaking change so I'm a bit reluctant. But I guess RN devs are pretty used to that by now haha. Don't think I've had a RN release that didn't break my app. |
oblador
added a commit
that referenced
this pull request
Oct 8, 2015
|
Fixed in 0.8.0. |
|
Awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows Facebook's internal pathing for their private modules - and allows other packagers (such as react-native-webpack-server) to properly resolve these guys.
See magus/react-native-facebook-login#25 and mjohnston/react-native-webpack-server#87 for some background