-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Webpack keeping fontFamily parameter for iOS #778
Conversation
Think this actually also broke iOS, did you try your changes? Anyway, I refactored it and think it should be fine now. Please test with your setup, and the example project. |
You are right, I forgot the |
Please do! |
@yairopro Could you fix the lint error and test that this PR works on iOS and Android? Would like to get it in the next release along with some other breaking changes. |
I won't be able to check it before sunday, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run tested this on iOS
Any chance we can get an example of what might need to change in webpack to support this change? The file name does not match the font name so browsers are not loading fonts in version 5.x. Thanks! |
Disregard my last message. Anyone coming here using Material UI Icons, for version 5.x you need to change the font family in your font-face style injector from "Material Icons" to "MaterialIcons". This is working for me
|
No description provided.