Support guess field #196
Support guess field #196
Conversation
There was a problem hiding this comment.
Hi @jxnu-liguobin - thanks for making this. Looks pretty great. I've left you a few suggestions & comments - mostly rust pointers. Hope you find them helpful.
You also need to run cargo fmt on the code to get it formatted correctly - CI is complaining about that just now. You may also need to merge in master, as I fixed a broken test on master earlier today.
You mentioned testing in your commit message: as this code is mostly error messages output from macros we use trybuild to test it. There are one or two examples here currently - you can add a .rs file to the cases folder that contains a mis-spelled field or enum, then you can reference that file in a test in this file. When you run cargo test trybuild will try to compile your .rs file - you need to make sure it fails with the compile error that you added. If you then run TRYBUILD=overwrite cargo test then trybuild will commit the error output so that the tests know what error to expect.
Let me know if you want help with anything - I am happy to make some of the changes myself if you'd rather (know that getting some bits of rust right can be tricky for newcomers) or just offer advice with any problems you run into.
jxnu-liguobin
force-pushed
the
support-guess-field
branch
from
5adefa8
to
743874c
Compare
There was a problem hiding this comment.
This is great @jxnu-liguobin - thanks again for taking it on. Got one small comment, but I may just merge and do it myself on master - wanting to get a release out today with this and a few other bits.
| @@ -6,6 +6,7 @@ pub mod input_object_derive; | |||
| pub mod query_dsl; | |||
| pub mod query_module; | |||
| pub mod scalar_derive; | |||
| pub mod suggestions; | |||
There was a problem hiding this comment.
Don't think we want this module as part of the public interface of the crate, can we make it private please:
| pub mod suggestions; | |
| mod suggestions; |
public/private in rust might work a bit different from what you're used to - private things can still be accessed by any children of the module where the private thing was declared.
Why are we making this change?
What effects does this change have?
I just tried, only compiled, and didn't know how to test it