Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actual error handling #4

Closed
2 tasks
obmarg opened this issue Feb 14, 2021 · 0 comments · Fixed by #20
Closed
2 tasks

Actual error handling #4

obmarg opened this issue Feb 14, 2021 · 0 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@obmarg
Copy link
Owner

obmarg commented Feb 14, 2021 •
edited
Loading

The crate is currently very rubbish at handling errors: there's unwraps all over the place, some errors are just ignored, the Error type is just an empty placeholder struct.

This issue is to track fixing those various issues.

  • All the unwraps.
  • The return inside sender_loop probably needs to do something
@obmarg obmarg added the bug Something isn't working label Feb 14, 2021
@obmarg obmarg mentioned this issue Feb 14, 2021
Merged
@BratSinot BratSinot mentioned this issue May 28, 2021
Merged
obmarg pushed a commit that referenced this issue May 30, 2021
@BratSinot
Unwrap all unwrap() and expect() to actual errors. (#20)
8ffb424 
Fixes #4 
Also playing a little after merge this with into #19 (in my branch `all_changes`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unwrap all unwrap() and expect() to actual errors.
1 participant
@obmarg