Obsolete behavioral control of excretion #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed equivalence axiom from phenotype branch.
Move defecation and urination to subclasses of emission.
Deprecated Excretion.
|
Sorry @DitchingIt - I am not the right person for reviewing content changes to any ontology (I have a rule: don't look at content - else I will never be able to do any work); I would recommend @sbello or @rays22 as reviewers |
rays22
requested changes
Mar 1, 2023
There was a problem hiding this comment.
Please, do not obsolete NBO:0000038 behavioral control of excretion.
Instead, remove the axiom
- Equivalent to:
emission behavior and is_about some excretion
Fo further explanation, please find my comments here.
|
Agree with @rays22 just remove the axiom. Behavioral control of excretion is still a valid term even if GO is eliminating the process excretion. |
|
Hi @rays22 |
matentzn
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115