Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meis2 Cluster #154

Closed
shawntanzk opened this issue Aug 5, 2021 · 7 comments
Closed

Meis2 Cluster #154

shawntanzk opened this issue Aug 5, 2021 · 7 comments
Assignees

Comments

@shawntanzk
Copy link
Collaborator

shawntanzk commented Aug 5, 2021

It turns out there are two nodes called Meis2, a cluster and a node (which includes the Meis2 cluster and one other). Jeremy has changed the cluster "Meis2 (cluster)" to disambiguate

In terms of mapping, my suggestion (which Jeremy agrees with) is that Meis2 is mapped to the the one that will be called Meis2 (instead of the cluster one).

*note: Meis2 node includes Meis2 (cluster) and Meis2 Top2a

I am not sure that this is the case now, but with the updated files, I will check this.

@shawntanzk shawntanzk self-assigned this Aug 5, 2021
shawntanzk added a commit that referenced this issue Aug 5, 2021
X-like implementation for mouse taxonomy
Related to #151 & #154
@shawntanzk
Copy link
Collaborator Author

see 545cc01

@shawntanzk
Copy link
Collaborator Author

Mapping as root node in taxonomy_details.yaml is correct

@shawntanzk
Copy link
Collaborator Author

@dosumis just wanted to make sure you see this implementation before I close this issue

@dosumis
Copy link
Contributor

dosumis commented Aug 6, 2021

Confused by terminology: Meis2 cluster = leaf node? & Meis2 = grouping node for Meis2 (cluster) and Meis2 Top2a ?

Meis2 = root node for type. This is GABAergic, but not closely related to other GABAergic neurons. Is this correct?

@shawntanzk
Copy link
Collaborator Author

Confused by terminology: Meis2 cluster = leaf node? & Meis2 = grouping node for Meis2 (cluster) and Meis2 Top2a ?

yes this is correct, and according to Jeremy, the more accurate way to map Meis2 is to the grouping node

Meis2 = root node for type. This is GABAergic, but not closely related to other GABAergic neurons. Is this correct?

That is correct, as other taxonomies might not have GABAergic as the parent term for Meis2, we've done Meis2 as a root node and mapped the CL term to the grouping node

@dosumis
Copy link
Contributor

dosumis commented Aug 6, 2021

So mouse maps to 'Meis2 GABAergic cortical interneuron', but other species Meis2 nodes don't - at least for now. Is there a Meis2 node in the cross-species dendrogram?

@shawntanzk
Copy link
Collaborator Author

So mouse maps to 'Meis2 GABAergic cortical interneuron', but other species Meis2 nodes don't - at least for now. Is there a Meis2 node in the cross-species dendrogram?

I need to do research for the rest - it is on an issue at the moment that I will get to.
Just checked with cross-species dataset (CS202002270), there isn't Meis2 on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants