Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drains/supplies - should we represent at both the organ level and the organ part level? Should we use inference to do this? #2096

Open
dosumis opened this issue Oct 13, 2021 · 9 comments

Comments

@dosumis
Copy link
Contributor

dosumis commented Oct 13, 2021

@emquardokus wrote:

are we looking for a relationship to the organ per se or to the hilum itself, which is a part of the organ or are you lumping it altogether? The relationship I see described in the literature in anatomical terms is all the vessels entering or exiting via hilum. On the other hand the contents (blood or lymph) of said vessels can be draining or supplying said organ. Maybe it's a biology thing as I see this as 2 separate relationships... physical vessel to organ vs functional thing what it's doing.

On the general issue:

  • I'd like to document what the CCF use cases are for representing connection/supply/drains relationships in CCF.owl and wether this would require relationships both at the organ level and at the organ part level.
  • Rather than adding two relationships to Uberon for drains/supplies covering organ and organ part, I'd prefer to use reasoning. A simple property chain can be used to say that if X drains/supplies Y and Y part_of Z then X drain/supplies Z. That might be too strong though as part_of is transitive (every vessel supplies the whole body...). We could use GCIs to restrict this to the organ level instead. (drains some (part_of some kidney) subClassOf drains some kidney).
@dosumis dosumis transferred this issue from hubmapconsortium/ccf-validation-tools Oct 13, 2021
@dosumis
Copy link
Contributor Author

dosumis commented Oct 13, 2021

@cmungall - add property chains:

drains o part_of -> drains
supplies o part_of -> supplies

Yes or no?

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

@paolaroncaglia
Copy link
Contributor

Commenting to prevent staleness: this is a HuBMAP/ASCT+B ticket (linked to ASCT+B board in fact) and should not be closed.

@cmungall
Copy link
Member

cmungall commented Apr 12, 2022 via email

@github-actions github-actions bot removed the Stale label Apr 13, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Feb 9, 2023
@matentzn matentzn assigned ghost Feb 13, 2023
@ghost
Copy link

ghost commented Feb 13, 2023

@dosumis / @matentzn, will you kindly clarify what the action items are for this ticket?

@matentzn
Copy link
Contributor

@bvarner-ebi sorry for assigning you, you will most likely be unassigned - we need someone on the ticket (as it is listed in the priorities) but right now the action item is for

  • @dosumis to summarise the action items related for this ticket

@github-actions github-actions bot removed the Stale label Feb 14, 2023
@matentzn
Copy link
Contributor

See also #2453 where we are about to create more specific relation ships. @anitacaron can you try to understand how these issues relate?

@ghost ghost assigned dosumis Jul 11, 2023
@ghost ghost removed their assignment Sep 5, 2023
Copy link

github-actions bot commented Jan 8, 2024

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants