Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dorsal fin parent #262

Closed
wdahdul opened this issue May 30, 2013 · 2 comments
Closed

dorsal fin parent #262

wdahdul opened this issue May 30, 2013 · 2 comments
Assignees
@cmungall
Labels
autoclosed-unfixed This issue has been closed automatically. core

Comments

@wdahdul
Copy link
Member

wdahdul commented May 30, 2013

Currently dorsal fin is a subclass of fin, but should be moved to median fin (apparently this was an axiom lost from TAO).
@ghost ghost assigned cmungall May 30, 2013
cmungall added a commit that referenced this issue May 30, 2013
@cmungall
modified axioms for dorsal fin - was in_median_plane_of some dorsum, …
e062c93 
…changing to median plane of organism and a separate axiom for part_of dorsum. Addresses #262
@cmungall
Copy link
Member

it makes things difficult for the build pipeline if parts of core depend on ext. But we can remove the direct dependency, as this link should be inferred.

I've added an equiv axiom to median fin in ext: fin and in_median_plane_of some organism
(r3917)

the relationships for dorsal fin in core are now such that it will be inferred to be a subclass of median fin

Seems a bit rube goldberg-esque, sorry. It's on the right tracker to the best overall solution though.

Brings up some other issues

  • need to improve modularization strategy to account for reciprocal dependencies
  • in_median_plane_of
    • should be in BSPO
    • do we need a relation here? Is a class "median plane of organism" sufficient/better? I think it's fine as a relation, this should be an axis that is applicable to things other than organism

cmungall added a commit that referenced this issue Jun 20, 2013
@cmungall
Added EFO slim. Fixes #234
6730349 
 Added has_parts for epithelium and BM. Addresses #269
 Added taxon constraints for BM. Addresses #269
 Adding relationships for septal nuclei structures
 added and obsoleted adult eye primordium (EFO)
 Changed def of tongue - Robert Druzinsky. Addresses #256
 Added dermatocranium part_of dermal skeleton. This ensures any bones in the dermatocranium are auto-classified as dermal bones/ Fixes #265
 dc-rights added
 Renamed alula. Fixes #264
 NT: extraperitoneal space. Additional axioms for: epidural space, retroperitoneal space
 abdominal fat changes. Explicitly broadened grouping class. NTs: adipose tissue of abdominal region, visceral abdominal adipose tissue. Fixes #259
 fixed equiv between integumentary adnexa and integumentary projection
 modified axioms for dorsal fin - was in_median_plane_of some dorsum, changing to median plane of organism and a separate axiom for part_of dorsum. Addresses #262
 merged hypodermis fat layer into subcutaneous adipose tissue
 modifying relationships and label for hypodermal muscle layer (muscle is now located in adipose tissue rather than a part)
 fat pad synonyms
 split many latin synonyms derived from dbpedia that were previously accidentally concatenated
 Fixed relationship between PA 2 skeleton and PA 2. Addresses #258
 Removed part_of link between hyoid arch skeleton and facial skeleton. Mistake arising from viscerocranium confusion. Addresses #258
 Modified definition of cricoid cartilage from Robert Druzinsky, modified from AAO definition. Also disambiguated tissue composition from primary classification.  Fixes #257
 NTs for subtypes of gustatory epithelium and removed restriction that taste buds were always on (papillae of) tongue
cmungall added a commit that referenced this issue Jul 5, 2013
@cmungall
modified axioms for dorsal fin - was in_median_plane_of some dorsum, …
16862cc 
…changing to median plane of organism and a separate axiom for part_of dorsum. Addresses #262
cmungall added a commit that referenced this issue Jul 5, 2013
@cmungall
Added EFO slim. Fixes #234
a6cba47 
 Added has_parts for epithelium and BM. Addresses #269
 Added taxon constraints for BM. Addresses #269
 Adding relationships for septal nuclei structures
 added and obsoleted adult eye primordium (EFO)
 Changed def of tongue - Robert Druzinsky. Addresses #256
 Added dermatocranium part_of dermal skeleton. This ensures any bones in the dermatocranium are auto-classified as dermal bones/ Fixes #265
 dc-rights added
 Renamed alula. Fixes #264
 NT: extraperitoneal space. Additional axioms for: epidural space, retroperitoneal space
 abdominal fat changes. Explicitly broadened grouping class. NTs: adipose tissue of abdominal region, visceral abdominal adipose tissue. Fixes #259
 fixed equiv between integumentary adnexa and integumentary projection
 modified axioms for dorsal fin - was in_median_plane_of some dorsum, changing to median plane of organism and a separate axiom for part_of dorsum. Addresses #262
 merged hypodermis fat layer into subcutaneous adipose tissue
 modifying relationships and label for hypodermal muscle layer (muscle is now located in adipose tissue rather than a part)
 fat pad synonyms
 split many latin synonyms derived from dbpedia that were previously accidentally concatenated
 Fixed relationship between PA 2 skeleton and PA 2. Addresses #258
 Removed part_of link between hyoid arch skeleton and facial skeleton. Mistake arising from viscerocranium confusion. Addresses #258
 Modified definition of cricoid cartilage from Robert Druzinsky, modified from AAO definition. Also disambiguated tissue composition from primary classification.  Fixes #257
 NTs for subtypes of gustatory epithelium and removed restriction that taste buds were always on (papillae of) tongue
@gouttegd gouttegd added the autoclosed-unfixed This issue has been closed automatically. label Aug 3, 2021
@gouttegd
Copy link
Collaborator

gouttegd commented Aug 3, 2021

WARNING: This issue has been automatically closed because it has not been updated in more than 3 years. Please re-open it if you still need this to be addressed addressed addressed – we are now getting some resources to deal with such issues.

@gouttegd gouttegd closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmungall cmungall

Labels
autoclosed-unfixed This issue has been closed automatically. core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cmungall @wdahdul @gouttegd