Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERON:0002066 name: umbilical vein and UBERON:0001310 name: umbilical artery #328

Closed
ANiknejad opened this issue Sep 9, 2013 · 3 comments

Comments

@ANiknejad
Copy link

Hi Chris,

UBERON:0002066
name: umbilical vein
external_definition "Extraembryonic part of the vein passing through the umbilical cord to the fetus and returning the purified and nutrient blood from the placenta.

sounds like this external_definition is too restrictive, in fact:

"Fetal oxygenated blood is returned from the placenta to the fetus by the umbilical vein. This vein enters the abdomen at the umbilicus and passes upward to the liver."

http://www.ajronline.org/doi/full/10.2214/ajr.185.2.01850541

So, I guess, a specific 'extraembryonic portion of umbilical vein' should exist, as exists
UBERON:0011693
name: extraembryonic portion of umbilical artery

Also, while it exists a specific term for the embryo portion of the umbilical artery

UBERON:0011694
name: embryo portion of umbilical artery

this is not the case for the umbilical vein.

Thank you.

Anne Niknejad

cmungall added a commit that referenced this issue Sep 9, 2013
@cmungall
Copy link
Member

cmungall commented Sep 9, 2013

Click on the diff link above and let me know what you think.

Still not 100% satisfactory. We may need to add L/R for the embryo portions to properly align with EHDAA2, which is a bit annoying.

I think these may mean the embryo part, but it's not clear.


 / [EHDAA2:0004540](http://purl.obolibrary.org/obo/EHDAA2_0004540) ! embryonic venous capillary plexus
  df [EHDAA2:0004526](http://purl.obolibrary.org/obo/EHDAA2_0004526) ! body venous capillary plexus
   df [EHDAA2:0000967](http://purl.obolibrary.org/obo/EHDAA2_0000967) ! umbilical vein left  
   df [EHDAA2:0001761](http://purl.obolibrary.org/obo/EHDAA2_0001761) ! umbilical vein right  
 / [EHDAA2:0004546](http://purl.obolibrary.org/obo/EHDAA2_0004546) ! zygote
  df [EHDAA2:0000005](http://purl.obolibrary.org/obo/EHDAA2_0000005) ! morula (2-16 cells)
   df [EHDAA2:0000830](http://purl.obolibrary.org/obo/EHDAA2_0000830) ! inner cell mass
    df [EHDAA2:0000444](http://purl.obolibrary.org/obo/EHDAA2_0000444) ! epiblast
     df [EHDAA2:0001128](http://purl.obolibrary.org/obo/EHDAA2_0001128) ! mesoderm
      df [EHDAA2:0000919](http://purl.obolibrary.org/obo/EHDAA2_0000919) ! lateral plate mesoderm
       df [EHDAA2:0001903](http://purl.obolibrary.org/obo/EHDAA2_0001903) ! splanchnopleure
        df [EHDAA2:0004526](http://purl.obolibrary.org/obo/EHDAA2_0004526) ! body venous capillary plexus
         df [EHDAA2:0000967](http://purl.obolibrary.org/obo/EHDAA2_0000967) ! umbilical vein left  
         df [EHDAA2:0001761](http://purl.obolibrary.org/obo/EHDAA2_0001761) ! umbilical vein right  
      df [EHDAA2:0003241](http://purl.obolibrary.org/obo/EHDAA2_0003241) ! mesoderm blood islands
       df [EHDAA2:0000936](http://purl.obolibrary.org/obo/EHDAA2_0000936) ! left dorsal aorta
        df [EHDAA2:0000966](http://purl.obolibrary.org/obo/EHDAA2_0000966) ! umbilical artery left  
       df [EHDAA2:0001720](http://purl.obolibrary.org/obo/EHDAA2_0001720) ! right dorsal aorta
        df [EHDAA2:0001760](http://purl.obolibrary.org/obo/EHDAA2_0001760) ! umbilical artery right  
     df [EHDAA2:0001626](http://purl.obolibrary.org/obo/EHDAA2_0001626) ! reticulum
      df [EHDAA2:0000474](http://purl.obolibrary.org/obo/EHDAA2_0000474) ! extraembryonic mesoderm
       df [EHDAA2:0000314](http://purl.obolibrary.org/obo/EHDAA2_0000314) ! connecting stalk mesenchyme
        df [EHDAA2:0003242](http://purl.obolibrary.org/obo/EHDAA2_0003242) ! connecting stalk blood islands
         df [EHDAA2:0000937](http://purl.obolibrary.org/obo/EHDAA2_0000937) ! extraembryonic umbilical artery left
          df [EHDAA2:0000966](http://purl.obolibrary.org/obo/EHDAA2_0000966) ! umbilical artery left  
         df [EHDAA2:0000938](http://purl.obolibrary.org/obo/EHDAA2_0000938) ! extraembryonic umbilical vein left
          df [EHDAA2:0000967](http://purl.obolibrary.org/obo/EHDAA2_0000967) ! umbilical vein left  
         df [EHDAA2:0001721](http://purl.obolibrary.org/obo/EHDAA2_0001721) ! extraembryonic umbilical artery right
          df [EHDAA2:0001760](http://purl.obolibrary.org/obo/EHDAA2_0001760) ! umbilical artery right  
         df [EHDAA2:0001722](http://purl.obolibrary.org/obo/EHDAA2_0001722) ! extraembryonic umbilical vein right
          df [EHDAA2:0001761](http://purl.obolibrary.org/obo/EHDAA2_0001761) ! umbilical vein right  

with timings:

 / [EHDAA2:0004540](http://purl.obolibrary.org/obo/EHDAA2_0004540) ! embryonic venous capillary plexus [ends_at: "CS20"] [starts_at: "CS09"]
  df [EHDAA2:0004526](http://purl.obolibrary.org/obo/EHDAA2_0004526) ! body venous capillary plexus [ends_at: "CS20"] [starts_at: "CS09"]
   df [EHDAA2:0000967](http://purl.obolibrary.org/obo/EHDAA2_0000967) ! umbilical vein left   [ends_at: "CS20"] [starts_at: "CS09"]
   df [EHDAA2:0001761](http://purl.obolibrary.org/obo/EHDAA2_0001761) ! umbilical vein right   [ends_at: "CS14"] [starts_at: "CS09"]
 / [EHDAA2:0004546](http://purl.obolibrary.org/obo/EHDAA2_0004546) ! zygote [ends_at: "CS01"] [starts_at: "CS01"]
  df [EHDAA2:0000005](http://purl.obolibrary.org/obo/EHDAA2_0000005) ! morula (2-16 cells) [ends_at: "CS02"] [starts_at: "CS02"]
   df [EHDAA2:0000830](http://purl.obolibrary.org/obo/EHDAA2_0000830) ! inner cell mass [ends_at: "CS04"] [starts_at: "CS03"]
    df [EHDAA2:0000444](http://purl.obolibrary.org/obo/EHDAA2_0000444) ! epiblast [ends_at: "CS05c"] [starts_at: "CS05a"]
     df [EHDAA2:0001128](http://purl.obolibrary.org/obo/EHDAA2_0001128) ! mesoderm [ends_at: "CS13"] [starts_at: "CS06b"]
      df [EHDAA2:0000919](http://purl.obolibrary.org/obo/EHDAA2_0000919) ! lateral plate mesoderm [ends_at: "CS13"] [starts_at: "CS09"]
       df [EHDAA2:0001903](http://purl.obolibrary.org/obo/EHDAA2_0001903) ! splanchnopleure [ends_at: "CS10"] [starts_at: "CS09"]
        df [EHDAA2:0004526](http://purl.obolibrary.org/obo/EHDAA2_0004526) ! body venous capillary plexus [ends_at: "CS20"] [starts_at: "CS09"]
         df [EHDAA2:0000967](http://purl.obolibrary.org/obo/EHDAA2_0000967) ! umbilical vein left   [ends_at: "CS20"] [starts_at: "CS09"]
         df [EHDAA2:0001761](http://purl.obolibrary.org/obo/EHDAA2_0001761) ! umbilical vein right   [ends_at: "CS14"] [starts_at: "CS09"]
      df [EHDAA2:0003241](http://purl.obolibrary.org/obo/EHDAA2_0003241) ! mesoderm blood islands [ends_at: "CS08"] [starts_at: "CS06b"]
       df [EHDAA2:0000936](http://purl.obolibrary.org/obo/EHDAA2_0000936) ! left dorsal aorta [ends_at: "CS14"] [starts_at: "CS09"]
        df [EHDAA2:0000966](http://purl.obolibrary.org/obo/EHDAA2_0000966) ! umbilical artery left   [ends_at: "CS20"] [starts_at: "CS10"]
       df [EHDAA2:0001720](http://purl.obolibrary.org/obo/EHDAA2_0001720) ! right dorsal aorta [ends_at: "CS20"] [starts_at: "CS09"]
        df [EHDAA2:0001760](http://purl.obolibrary.org/obo/EHDAA2_0001760) ! umbilical artery right   [ends_at: "CS20"] [starts_at: "CS10"]
     df [EHDAA2:0001626](http://purl.obolibrary.org/obo/EHDAA2_0001626) ! reticulum [ends_at: "CS05b"] [starts_at: "CS05b"]
      df [EHDAA2:0000474](http://purl.obolibrary.org/obo/EHDAA2_0000474) ! extraembryonic mesoderm [ends_at: "CS05c"] [starts_at: "CS05c"]
       df [EHDAA2:0000314](http://purl.obolibrary.org/obo/EHDAA2_0000314) ! connecting stalk mesenchyme [ends_at: "CS20"] [starts_at: "CS06a"]
        df [EHDAA2:0003242](http://purl.obolibrary.org/obo/EHDAA2_0003242) ! connecting stalk blood islands [ends_at: "CS08"] [starts_at: "CS07"]
         df [EHDAA2:0000937](http://purl.obolibrary.org/obo/EHDAA2_0000937) ! extraembryonic umbilical artery left [ends_at: "CS20"] [starts_at: "CS09"]
          df [EHDAA2:0000966](http://purl.obolibrary.org/obo/EHDAA2_0000966) ! umbilical artery left   [ends_at: "CS20"] [starts_at: "CS10"]
         df [EHDAA2:0000938](http://purl.obolibrary.org/obo/EHDAA2_0000938) ! extraembryonic umbilical vein left [ends_at: "CS20"] [starts_at: "CS09"]
          df [EHDAA2:0000967](http://purl.obolibrary.org/obo/EHDAA2_0000967) ! umbilical vein left   [ends_at: "CS20"] [starts_at: "CS09"]
         df [EHDAA2:0001721](http://purl.obolibrary.org/obo/EHDAA2_0001721) ! extraembryonic umbilical artery right [ends_at: "CS20"] [starts_at: "CS09"]
          df [EHDAA2:0001760](http://purl.obolibrary.org/obo/EHDAA2_0001760) ! umbilical artery right   [ends_at: "CS20"] [starts_at: "CS10"]
         df [EHDAA2:0001722](http://purl.obolibrary.org/obo/EHDAA2_0001722) ! extraembryonic umbilical vein right [ends_at: "CS14"] [starts_at: "CS09"]
          df [EHDAA2:0001761](http://purl.obolibrary.org/obo/EHDAA2_0001761) ! umbilical vein right   [ends_at: "CS14"] [starts_at: "CS09"]

@ANiknejad
Copy link
Author

Thank you Chris!
To be more consistent, we should follow

id: UBERON:0011696
name: left extraembryonic umbilical artery
namespace: uberon
synonym: "extraembryonic umbilical artery left" EXACT [EHDAA2:0000937]

that means, to put 'extraembryonic portion of' only for the total vein or artery
and to specify L/R by following the model above (L/R at the first position in the name, and at the last position in the synonym)

I would suggest:

+[Term]
+id: UBERON:0014787
***_+name: left extraembryonic umbilical vein_
+intersection_of: UBERON:0014786 ! extraembryonic portion of umbilical vein
+intersection_of: in_left_side_of UBERON:0000468 ! multi-cellular organism
+xref: EHDAA2:0000938 ! extraembryonic umbilical vein left
+synonym: "extraembryonic umbilical vein left" EXACT [EHDAA2:0000938]

and

+[Term]
+id: UBERON:0014788
_+name: right extraembryonic umbilical vein_
+intersection_of: UBERON:0014786 ! extraembryonic portion of umbilical vein
+intersection_of: in_right_side_of UBERON:0000468 ! multi-cellular organism
+xref: EHDAA2:0001722 ! extraembryonic umbilical vein right
+synonym: "extraembryonic umbilical vein right" EXACT [EHDAA2:0001722]

Thank you again

Anne

cmungall added a commit that referenced this issue Sep 10, 2013
…yonic portions. Fixes issue #328

     * Removed redundant synonym. Fixes issue #329
     * NTs: cloacal muscles
     * Fixed typo in syn. Fixes issue #327
mellybelly pushed a commit that referenced this issue Sep 19, 2013
# By Chris Mungall
# Via Chris Mungall
* 'master' of https://github.com/obophenotype/uberon: (27 commits)
  * Fixed EquivClass axioms for axiom muscl(e/ature) to restrict to axial skeleton
  fixed typos
  null
  * Merged skeletal muscle tissue of leg, pelvic girdle into muscle organ classes
  * NT: Annule of Zinn  * Adding comments and relationships to eye muscles
  * Removed non-unicode character. Fixes #332
  * Applied rule for adding muscle organ part_of musculature
  * Musculature overhaul - ensured musculature complete w.r.t. muscle organs
  fix
  * Various tongue muscle refactoring. Addresses issue #331   * NT: lingual septum   * Aligned some text defs with FEED   * Improved some wikipedia derived defs   * Changed equiv axioms for tongue muscle, extrinsic and intrinsic   * Made child terms complete wrt attachments
  Merging skeletal muscle of arm into muscle of arm.
  null
  * Remapped EHDAA2, added notes on eye smooth muscle. Addresses #324
  null
  * Added contribution of umbilical cord to umbilicus
  * Changed naming convention for extraembryonic umbilical veins. Fixes issue #328
  * NTs for subdivision of umbilical vein into extraembryonic and embryonic portions. Fixes issue #328      * Removed redundant synonym. Fixes issue #329      * NTs: cloacal muscles      * Fixed typo in syn. Fixes issue #327
  typo fixed
  typo fixed
  typo fixed
  ...
@ANiknejad
Copy link
Author

+UBERON:0014786 extraembryonic portion of umbilical vein
+UBERON:0014787 extraembryonic portion of left umbilical vein
+UBERON:0014788 extraembryonic umbilical vein right
+UBERON:0014789 embryo portion of umbilical vein

well, I guess,
+UBERON:0014786 extraembryonic portion of umbilical vein
+UBERON:0014787 extraembryonic portion of left umbilical vein
+UBERON:0014788 extraembryonic umbilical vein right

should be removed....even if I asked for the terms, I am sorry! I was confused by terms proposed by EHDAA2 but looking more carefully inside the literature, I guess, 'Umbilica'l is a broad term with includes both embryo and extraembryonic parts.

http://www.embryology.ch/anglais/pcardio/venen02.html

There is only one umbilical vein in the umbilical cord, the 'unpaired umbilical vein' which is then extraembryonic (maybe to create this term?), while there are 2 umbilical arteries which can be defined both inside the embryo and outside (means in the umbilical cord)

So maybe we should have:

unpaired umbilical vein (umbilical cord vein)
umbilical veins (embryo, both right and left)
umbilical arteries (embryo portion, left and right, and extraembryonic portion, left and right)

Needs anyway feedback from anatomists, I guess

Thank you

Anne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants