Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor typo #418

Closed
tfhayamizu opened this issue Apr 16, 2014 · 9 comments
Closed

minor typo #418

tfhayamizu opened this issue Apr 16, 2014 · 9 comments

Comments

@tfhayamizu
Copy link

UBERON:0007094 "visceral muculature" should be "visceral musculature"

@cmungall
Copy link
Member

It's not clear that we should even keep 'visceral musculature' and 'somatic musculature' in the ontology

@dosumis
Copy link
Contributor

dosumis commented Apr 16, 2014

These classes are needed for arthropods. May be useful to keep general classes defined wrt to anatomy rather than ultrastructures (visceral is always smooth in vertebrates, but not in invertebrates).

@tfhayamizu
Copy link
Author

I was going to comment further on this, albeit for a different reason. I have been working towards harmonizing the EMAPA and MA (and hopefully Uberon) representations of "muscle" in general. I have identified some basic issues, and have some preliminary suggestions for improvement. Some of these are summarized in the attached diagram:
musculature

@tfhayamizu
Copy link
Author

note: Suggestions for relationships to replace are shown in red, with possible new ones bold purple. Also shown are suggested xrefs to newly added EMAPA terms (shown in blue).

@cmungall
Copy link
Member

Great! @RDruzinsky and @dosumis may have comments.

@tfhayamizu
Copy link
Author

Planning to add a term for "muscle layer" to EMAPA to accommodate classification for many terms introduced by GUDMAP.

Moreover, I would greatly like to hear from others about the subject in general, especially with regards to how deal with non-skeletal muscle, as well as how to best represent the class.

@cmungall
Copy link
Member

I think having a 'muscle layer' grouping is a good idea. The FMA distinguishes between 'muscle layer' and 'subdivision of smooth muscle layer' but it's not clear we need this.

We recently did some fixes in skeletal muscles after David pointed out some issues. We have a reasonably clear distinction now between skeletal muscle organs and the (portions of) tissue that make them up, Currently for smooth muscle some things are classified as a mix of layers, tissues, but perhaps this is fine.

@tfhayamizu
Copy link
Author

Can you explain the rationale for having most named muscle groups (e.g. abductor muscle) and named muscles (e.g. sartorius) as subclasses of "muscle organ" rather than "skeletal muscle organ"? Have there been changes made that are not yet in the basic.obo file?

@cmungall
Copy link
Member

I think they should be subclasses of SMO.

cmungall added a commit that referenced this issue Apr 24, 2014
    * Using zygapophysis as primary label issue #421
 * Neuro
    * Added more NN xrefs
    * Various NTs
 * Mammalian
    * NT: baleen feeding system (whale)
    * NT: lunge feeding organ
 * Misc
    * High level xref for XAO. #422
    * NR: has_component
    * PA2 def. Fixes #416 -- ZFIN:yb
    * classifying to more specific CARO classes
    * Fixed typo. Fixes #418
    * Removing stray CARO classes from composite builds. Issue #422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants