Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP_0001913 and HP_0012234 are inferred to be equiv #178

Closed
nicolevasilevsky opened this issue Sep 7, 2016 · 9 comments
Closed

HP_0001913 and HP_0012234 are inferred to be equiv #178

nicolevasilevsky opened this issue Sep 7, 2016 · 9 comments
Assignees

Comments

@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Sep 7, 2016

HP_0001913 Granulocytopenia and are inferred to be equiv classes.

HP_0001913 Granulocytopenia
Logical def:
'has part' some
('decreased amount' and ('inheres in' some
(granulocyte and ('part of' some blood))) and ('has modifier' some abnormal))

HP_0012234 Agranulocytosis
Logical def:
'has part' some
('decreased amount' and ('inheres in' some granulocyte) and ('has modifier' some abnormal))

I am not sure why these are inferred to be equivalent.
Related to #149

@cmungall @pnrobinson

@nicolevasilevsky nicolevasilevsky changed the title HP_0001913 and HP_0012234 are infer HP_0001913 and HP_0012234 are inferred to be equiv Sep 7, 2016
@nicolevasilevsky
Copy link
Member Author

@drseb @cmungall @pnrobinson
Are these are inferred to be equiv because granulocyte is a blood cell?

There is no explanation in Protege.

@pnrobinson
Copy link

Agranulocytosis should be "lacks parts", it is not just reduced, it is absent of course.

@nicolevasilevsky
Copy link
Member Author

Thanks Peter! I updated the logical def to use 'lacking all parts of type'

@balhoff
Copy link
Member

balhoff commented Jun 27, 2017

I still cannot understand how the two original expressions are equivalent. @cmungall this is a puzzler.

@balhoff
Copy link
Member

balhoff commented Jun 27, 2017

Oh! I see, should have been obvious. Agranulocytosis is asserted to be a subclass of Granulocytopenia. However the definition of Granulocytopenia was a subclass of the definition of Agranulocytosis. Reciprocal subclasses are equivalent.

@cmungall
Copy link
Member

@nicolevasilevsky do we have a reason to use (granulocyte and ('part of' some blood)) in one and plain granulocyte in the other? We might think a reasoner would infer these two expressions to be equivalent but in fact CL lacks any axiom that restricts granulocytes to blood (presumably as they can be found in lymph too)

@nicolevasilevsky
Copy link
Member Author

good point, I will add (granulocyte and ('part of' some blood)) to HP_0012234 Agranulocytosis

@cmungall
Copy link
Member

But the text says

def: "Marked decrease in the number of granulocytes." [HPO:probinson]

It's always a red flag if the OWL definition starts dropping in extra clauses that are not in the text

@pnrobinson
Copy link

-penia means simply reduced (like penurious)
-a... means complete lack of
so basically Agranulocytosis is a severe form of Granulocytopenia

I think Nicole already changed the logical definitions and now all seems to be correct. I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants