Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern for representing lesions and their shape required #302

Open
matentzn opened this issue Dec 13, 2018 · 12 comments
Open

Pattern for representing lesions and their shape required #302

matentzn opened this issue Dec 13, 2018 · 12 comments

Comments

@matentzn
Copy link
Collaborator

Some POs such as PLANP and MP represent lesions. PLANP in particular needs to represent lesions and their very particular shape. In MP, some lesions are represented as process phenotypes (example: skin lesions).

How do we represent, for example, a star shaped lesion of the tail?

@srobb1, @sbello, @dosumis, @pnrobinson

@srobb1
Copy link
Collaborator

srobb1 commented Dec 13, 2018

I was thinking about this:

  1. The shape inheres in the lesion
  2. and the shaped lesion inheres in the tail
'has part' some 
    (   
        ('star shaped' and ('inheres in' some 'lesion')   )
	and ('inheres in' some 'tail' )
         and ('has modifier' some abnormal)
   )

@sbello
Copy link

sbello commented Dec 13, 2018

Double 'inheres in' is not allowed, maybe substitute 'occurs in' for the second one? Based on the BFO definition I think this is correct if 'lesion' is a process term as in the MP example. Where is 'lesion' coming from?

@srobb1
Copy link
Collaborator

srobb1 commented Dec 13, 2018

@sbello
So far the best 'lesion' I have found is http://purl.obolibrary.org/obo/NCIT_C3824. Not sure if this works with the need for it to be a process term.

Thank you for helping to work through this with me.

@sbello
Copy link

sbello commented Dec 13, 2018

Nope, reading the NCIT definition the lesion sounds like a material entity not a process. So, we're back to entity located on/in another entity. Closest pattern I can find is molecular entity in a location. This has the pattern '('inheres_in' some (%s and ('part_of' some %s)))' I think that should work here. So we would end up with

'has part' some
(
('star shaped' and ('inheres in' some (lesion and ('part of' some tail)) )

     and ('has modifier' some abnormal)

)

Link to reference pattern https://github.com/obophenotype/upheno/blob/master/src/patterns/decreasedLevelOfMolecularEntityInLocation.yaml

@pnrobinson
Copy link

Is there anything wrong with modelling lesions as material entities (I think this is much more accurate than process)?

@sbello
Copy link

sbello commented Dec 13, 2018

No problem with modeling lesions as material entities. I also thinks this makes more sense than the current MP pattern which strikes me as too broad. The issue was occurs in BFO specifies process to entity so we can't use that relationship. The last pattern above is appropriate for entity to entity.

@dosumis
Copy link
Contributor

dosumis commented Dec 13, 2018 via email

@srobb1
Copy link
Collaborator

srobb1 commented Dec 13, 2018

This looks good. I will try out this out:

'has_part' some (%s and ('inheres_in' some (%s and ('part_of' some %s))) and ('qualifier' some 'abnormal'))

Thank you!

@matentzn
Copy link
Collaborator Author

If the lesions are lesions and do not need to be further classified (i.e. different subtypes of lesions), I suggest to specify the pattern a bit (fix the lesion):

'has_part' some (%s and ('inheres_in' some ('lesion' and ('part_of' some %s))) and ('qualifier' some 'abnormal'))

There is always a tension between the flexibility of a pattern and possible issues of interoperability. 3 variables should IMHO be used only in very specific circumstances (relational qualities etc).

@dosumis
Copy link
Contributor

dosumis commented Dec 14, 2018

I think the generalized pattern we need to agree on here is

Q inheres_in some ( {pathological entity} & R some {anatomical entity})

Should R be part_of or located_in? I favour the latter but this should be decided in co-ordination with Mondo.

If we don't want to subtype lesions (apart from by where they are - which we are specifying here using a compositional entity), then I agree with Nico that we should make a lesion pattern.

@pnrobinson
Copy link

There are at least two patterns that one encounters in medicine.

  1. star-shaped lesion of the autopod (to stay species neutral). In this case, "lesion" is very generic and it's "star-shaped" that is providing the information
  2. stage IIIb adenocarcinoma of (anatomy) with tumor infiltrating macrophages (or possibly a list of similar attributes). Here the "stage" provides information about the spread of the cancer (and is thus possibly better conceptualized as a disease), but the anatomy and the "adenocarcinoma" provide information about the primary phenotypic feature (the tumor), that is further specified by the histological findings.

The HPO currently has terms that correspond to (1) (some of the terms). In cancer and in many other areas, it will be important to model phenotypes of category (2) in some way (possibly not as precomposed terms). If we think that we want to use OWL to reason over terms like this, then we should be sure that they will be compatible.

@srobb1
Copy link
Collaborator

srobb1 commented Dec 14, 2018

I created a pull request #303 with a suggested pattern to move forward. Any comments and/or corrections on the pattern are welcome and appreciated. I made a note in the comments of the pull request that there are questions about the best relation to use, part_of or located_in.

Sofia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants