Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensory dendrite location relationship #382

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Sensory dendrite location relationship #382

merged 3 commits into from
Dec 11, 2020

Conversation

Clare72
Copy link
Contributor

@Clare72 Clare72 commented Jul 20, 2020

fixes #377

@Clare72 Clare72 requested a review from dosumis July 20, 2020 12:40
@dosumis
Copy link
Contributor

dosumis commented Dec 9, 2020

Hi @Clare72 - trying to tidy up old pull requests. Looks like there were a couple of pending suggesting edits on this - but perhaps not fixed/merged in because of divergence from master? If so, would you be happy to recreate and make a new pull request? Cheers, David

dosumis
dosumis reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

src/ontology/ro-edit.owl Outdated
AnnotationAssertion(oboInOwl:hasExactSynonym obo:RO_0013007 "has sensory terminal location")
AnnotationAssertion(rdfs:label obo:RO_0013007 "has sensory dendrite in"@en)
SubObjectPropertyOf(obo:RO_0013007 obo:RO_0002360)
ObjectPropertyDomain(obo:RO_0013007 ObjectUnionOf(obo:CL_0000101 ObjectSomeValuesFrom(obo:BFO_0000050 obo:CL_0000101)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make domain just neuron

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better - sensory neuron.

@Clare72 Clare72 merged commit 5a96a01 into master Dec 11, 2020
@Clare72 Clare72 deleted the sensory_dendrite branch December 11, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosumis dosumis dosumis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New relation - 'has sensory dendrite in'
2 participants
@Clare72 @dosumis