Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsoleting contains and contained in 693 #739

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Obsoleting contains and contained in 693 #739

merged 5 commits into from
Aug 16, 2023

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Jul 18, 2023 •
edited
Loading

Fixes #693

  • Obsoleting contains and contained in.
  • adding seeAlso to issue

@cmungall cmungall changed the title issue 693 Obsoleting contains and contained in 693 Jul 18, 2023
@wdduncan
Copy link
Collaborator

We need to make sure that ontologies which use contains are aware of the change. See list here:
https://www.ebi.ac.uk/ols4/ontologies/ro/properties/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FRO_0001019

Found in UBER Graph: AISM, ENVO, Uberon, COLAO, MP

cmungall added a commit to obophenotype/uberon that referenced this pull request Jul 28, 2023
@cmungall
Changing contains to be location_of. See oborel/obo-relations#739
bcb7cb4
@cmungall cmungall mentioned this pull request Jul 28, 2023
Merged
cmungall added a commit to EnvironmentOntology/envo that referenced this pull request Jul 28, 2023
@cmungall
Modifify containment relations to be location relations.
f3c5e83 
Should be merged before oborel/obo-relations#739

For full discussion, see oborel/obo-relations#693
@cmungall cmungall mentioned this pull request Jul 28, 2023
Closed
@cmungall
Copy link
Contributor Author

I think the MP one is a false positive (because it imports UBERON). Same of COLAO

I made PRs for UBERON and ENVO and an issue for AISM

@anitacaron anitacaron self-requested a review as a code owner August 7, 2023 14:30
@anitacaron anitacaron mentioned this pull request Aug 7, 2023
Merged
@mark-jensen mark-jensen mentioned this pull request Aug 16, 2023
Closed
@anitacaron anitacaron merged commit 56b2287 into master Aug 16, 2023
1 check passed
anitacaron added a commit to obophenotype/uberon that referenced this pull request Sep 5, 2023
@cmungall @anitacaron
Changing contains to be location_of. See oborel/obo-relations#739 (#2998
c9eeab8 
)

Co-authored-by: Anita Caron <anitacaron@users.noreply.github.com>
Co-authored-by: Anita Caron <anitac@ebi.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anitacaron anitacaron anitacaron approved these changes

@wdduncan wdduncan wdduncan approved these changes

Assignees

@cmungall cmungall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should contained_in be a sub-property of located_in?
3 participants
@cmungall @wdduncan @anitacaron