Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Japanese vaccination passport app #28

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Dec 22, 2021

Hello🙂

This PR proposes to add a new key for the Japanese vaccination passport app. This app was published officially on December 20 by the Japanese government agency (website: https://www.digital.go.jp/policies/posts/vaccinecert (in Japanese)). I think currently this repository has only the keys from the Canadian municipalities but I think this web app has the best UI among similar programs so I'd be happy to be able to use it to test and learn the Japanese vaccination data too.

I got the keys from this URL: https://vc.vrs.digital.go.jp/issuer/.well-known/jwks.json. Maybe you are not familiar with the Japanese government website but the domain digital.go.jp is under the control of the Digital Agency of the Japanese Government (Digital Agency - Wikipedia) so I believe you can also think of this as reliable keys.

Here is the first part of the decoded code of my card:

{
    "iss": "https://vc.vrs.digital.go.jp/issuer",
    "nbf": 1639970498.349618,
    "vc": {
        "type": [
            "https://smarthealth.cards#health-card",
            "https://smarthealth.cards#immunization",
            "https://smarthealth.cards#covid19"
        ],
        "credentialSubject": {
            "fhirVersion": "4.0.1",
            "fhirBundle": {
                "resourceType": "Bundle",
                "type": "collection",
                "entry": [
                    {
                        "fullUrl": "resource:0",
                        "resource": {
                            "resourceType": "Patient",
                            "name": [
                                {
                                    "use": "usual",
                                    "family": "\\u9ad8\\u6a4b",
                                    "given": [
                                        "\\u5b97\\u53f2"
                                    ]
                                },
                                {
                                    "use": "official",
                                    "family": "TAKAHASHI",
                                    "given": [
                                        "SHUUJI"
                                    ]
                                }
                            ],

Also, I tested it using my own vaccination certification QR code and it works without issues.

Before
Screen Shot 2021-12-20 at 15 54 31

After
Screen Shot 2021-12-20 at 15 56 43 copy

Thanks!

@shuuji3 shuuji3 changed the title Add a new key for Japanese vaccination passport app Add support for Japanese vaccination passport app Dec 22, 2021
@obrassard
Copy link
Owner

Hello @shuuji3 ! Thank you for your contribution, it looks good to me !

I will merge your PR 👍

@obrassard obrassard merged commit 3cf8265 into obrassard:main Dec 22, 2021
@shuuji3 shuuji3 deleted the add-japan branch December 23, 2021 03:15
@shuuji3
Copy link
Contributor Author

shuuji3 commented Dec 23, 2021

Thank you! 😀

I confirmed that it works on production environment too.

@shuuji3
Copy link
Contributor Author

shuuji3 commented Dec 23, 2021

@obrassard Sorry, I forgot to update README.md. Could you take a look at #29? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants