Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell toolbar covers cursor #291

Closed
mootari opened this issue Nov 18, 2021 · 8 comments
Closed

Cell toolbar covers cursor #291

mootari opened this issue Nov 18, 2021 · 8 comments
Labels
Bug Something isn't working Notebook Top N Common or popular

Comments

@mootari
Copy link
Member

mootari commented Nov 18, 2021

Describe the bug

Moving the cursor inside an editor scrolls the viewport to keep the cursor in view. However, when the cursor is moved towards the bottom, and the editor touches or extends beyond the bottom edge of the viewport, then the sticky toolbar covers the cursor for the approx. two bottom lines within the viewport.

Screenshots

Kapture 2021-11-19 at 00 54 37

(Apologies for the awful dither.)

Desktop (please complete the following information):

Chrome 95 on macOS 11.6.1

@CobusT CobusT added the Bug Something isn't working label Nov 19, 2021
@mootari
Copy link
Member Author

mootari commented Dec 5, 2021

The toolbar also covers the bottom of the history, which makes it difficult to see if the end has been reached:
image

@CobusT CobusT added the Top N Common or popular label Mar 8, 2022
@mootari
Copy link
Member Author

mootari commented Mar 26, 2022

Most importantly, the toolbar also covers search results. When a search result is clicked, the user still has to scroll down to see the highlighted match.

@CobusT
Copy link
Collaborator

CobusT commented Apr 18, 2022

@mootari Could you please retest this? In looking at the current behavior, it seems to be fixed.

  • toolbar doesn't cover history or search results panes anymore
  • when clicking on a search result, the match is visible without having to scroll.

@CobusT CobusT closed this as completed Apr 18, 2022
@mootari
Copy link
Member Author

mootari commented Apr 19, 2022

@CobusT

  1. Fixed: history is no longer covered by cell toolbar
  2. Fixed: cursor is no longer covered by cell toolbar or sticky header
  3. Still open: cell toolbar covers cursor. See demo:
    Kapture.2022-04-19.at.11.49.13.mp4

@CobusT
Copy link
Collaborator

CobusT commented Apr 19, 2022

Very strange. The first row scrolled into view, and the last row also did that, but the second row containing Math didn't. Can you send me the link of that notebook? I should probably recognize it by its content, but could find it...

@mootari
Copy link
Member Author

mootari commented Apr 19, 2022

It's the demo notebook ;)

I suspect that the second line is partially within the threshold that determines wether a line is "visible". Here I've added the CSS rule .cm-content > div { outline: 1px dotted #0005 } to the parent window:

image

Note that I cannot reopen this issue.

@mootari
Copy link
Member Author

mootari commented Apr 19, 2022

By the way, you can find published notebooks via their content by picking any phrase and searching for it in quotes, e.g.: https://observablehq.com/search?query=%22you+can+yield%22

@CobusT
Copy link
Collaborator

CobusT commented Apr 19, 2022

Haha, yes! I searched with pluses but without quotes... doh!

@CobusT CobusT reopened this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Notebook Top N Common or popular
Projects
None yet
Development

No branches or pull requests

2 participants