Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncaught front-matter errors #215

Closed
Fil opened this issue Nov 21, 2023 · 0 comments · Fixed by #243
Closed

uncaught front-matter errors #215

Fil opened this issue Nov 21, 2023 · 0 comments · Fixed by #243
Assignees
@Fil
Labels
bug Something isn’t working
Milestone
Early access

Comments

@Fil
Copy link
Contributor

Fil commented Nov 21, 2023

If the front-matter is invalid, the preview server can crash.

example:

---
toc:
  show: false
title: "Welcome"
dd==::1
---

we should probably try catch this:
https://github.com/observablehq/cli/blob/af451f56694c6fd207b0ef50b56c206bcf98aa52/src/markdown.ts#L381
@Fil Fil added the bug Something isn’t working label Nov 21, 2023
@mbostock mbostock added this to the Early access milestone Nov 22, 2023
@Fil Fil self-assigned this Nov 27, 2023
Fil added a commit that referenced this issue Nov 27, 2023
@Fil
closes #215
8e749b3
@Fil Fil mentioned this issue Nov 27, 2023
Merged
@Fil Fil removed their assignment Nov 27, 2023
@Fil Fil closed this as completed in #243 Nov 30, 2023
Fil added a commit that referenced this issue Nov 30, 2023
@Fil
handle invalid front-matter errors (#243)
47fe518 
Use an object config to skip gray-matter's caching (see jonschlinkert/gray-matter#166)
closes #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fil Fil

Labels
bug Something isn’t working
Projects
None yet
Milestone
Early access
Development

Successfully merging a pull request may close this issue.

handle invalid front-matter errors observablehq/framework
2 participants
@Fil @mbostock