Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import rewriting for ES modules that are in subdirectories #30

Closed
mbostock opened this issue Oct 18, 2023 · 2 comments · Fixed by #40
Closed

Fix import rewriting for ES modules that are in subdirectories #30

mbostock opened this issue Oct 18, 2023 · 2 comments · Fixed by #40
Assignees
@cinxmo
Labels
bug Something isn’t working good first issue Good for newcomers

Comments

@mbostock
Copy link
Member

As noted, the rewriteImports function currently assumes that the ES module is in the root folder, but it should be allowed to be in a subfolder.
@mbostock mbostock added the bug Something isn’t working label Oct 18, 2023
@cinxmo
Copy link
Contributor

cinxmo commented Oct 18, 2023

Interested in this one

@mbostock mbostock added the good first issue Good for newcomers label Oct 18, 2023
@cinxmo cinxmo self-assigned this Oct 19, 2023
@cinxmo
Copy link
Contributor

cinxmo commented Oct 19, 2023

I believe this is the relevant Slack convo

This was referenced Oct 23, 2023
Closed
Merged
@Fil Fil mentioned this issue Oct 26, 2023
Closed
@cinxmo cinxmo closed this as completed in #40 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cinxmo cinxmo

Labels
bug Something isn’t working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support relative imports observablehq/framework
2 participants
@mbostock @cinxmo