Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching a path that starts with “../” or “/” is not automatically promoted to a file attachment #59

Closed
mbostock opened this issue Oct 23, 2023 · 1 comment · Fixed by #40
Closed

Fetching a path that starts with “../” or “/” is not automatically promoted to a file attachment #59

mbostock opened this issue Oct 23, 2023 · 1 comment · Fixed by #40
Assignees
@cinxmo
Labels
bug Something isn’t working good first issue Good for newcomers

Comments

@mbostock
Copy link
Member

Like #30, but for fetch. We only check for ./ currently which doesn’t account for these other types of paths.

https://github.com/observablehq/cli/blob/62d025157ca5e07e002ee0104705032848307f0e/src/javascript/features.js#L68
@mbostock mbostock added bug Something isn’t working good first issue Good for newcomers labels Oct 23, 2023
@cinxmo
Copy link
Contributor

cinxmo commented Oct 23, 2023

will/should be fixed as part of #40 😁

@cinxmo cinxmo self-assigned this Oct 23, 2023
@cinxmo cinxmo mentioned this issue Nov 1, 2023
Merged
1 task
@cinxmo cinxmo closed this as completed in #40 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cinxmo cinxmo

Labels
bug Something isn’t working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support relative imports observablehq/framework
2 participants
@mbostock @cinxmo