implicit /+esm for JavaScript extensions #1174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: We reverted this in #1186 as it was breaking duckdb-wasm.
This makes imports such as this work out of the box:
Previously these imports would error because they require
/+esm
; now the/+esm
is added implicitly so it “just works.”This also fixes the default entry for deck.gl, so that this now works, too:
(I did see an error once about “multiple versions of luma detected”… but couldn’t reproduce it reliably.)