DRY tests #119
Merged
DRY tests #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit also fixes the regeneration of test/output following a fresh run; the package.json only created test/output, and so the tests would fail when test/output/imports did not exist. Regenerating test/output from scratch also identified that the test of a static npm protocol import added in #101 was inadvertently disabled in #40 (because the test file doesn’t end with -import.js and therefore is ignored). I fixed this by renaming the test to static-npm-import.js. |
mbostock
force-pushed
the
mbostock/dry-javascript-tests
branch
from
22b1911
to
363e257
Compare
cinxmo
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces some code duplication, and notably now generates a -changed.js so we can see test failures for imports.