Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inspector cleanup #1457

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix inspector cleanup #1457

merged 1 commit into from
Jun 13, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jun 13, 2024

The inspector replaces its contents when objects are expanded; this prevents display from being able to cleanup. To fix this, we retain the wrapper DIV element around the inspector contents. Fixes #1456.

@mbostock mbostock requested a review from Fil June 13, 2024 00:33
@mbostock mbostock merged commit 1b71e52 into main Jun 13, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/fix-inspector branch June 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanded objects are not cleaned up on invalidation
2 participants