relative fetch and FileAttachments #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
commented
Nov 17, 2023
Comment on lines
-8
to
+12
| output.insertLeft(node.arguments[0].start + 3, "_file/"); | ||
| const arg = node.arguments[0]; | ||
| const value = relativeUrl(sourcePath, "/_file/" + join(dirname(sourcePath), getStringLiteralValue(arg))); | ||
| output.replaceLeft(arg.start, arg.end, JSON.stringify(value)); |
There was a problem hiding this comment.
Note that this also fixes a bug where fetch rewrites didn't work for files in subdirectories:
If you had this in javascript/files.md:
fetch("../file.csv")it would have been compiled to fetch(".._file//file.csv") 👎
(with this PR it becomes fetch("../_file/file.csv") 👍); tested in input/build/files/
Fil
commented
Nov 17, 2023
| @@ -330,7 +331,7 @@ function normalizePieceHtml(html: string, root: string, sourcePath: string, cont | |||
| const path = getLocalPath(sourcePath, href); | |||
| if (path) { | |||
| context.files.push({name: href, mimeType: mime.getType(href)}); | |||
| element.setAttribute("href", `/_file/${path}`); | |||
| element.setAttribute("href", relativeUrl(sourcePath, `/_file/${path}`)); | |||
There was a problem hiding this comment.
rewriting <link href> was not tested; now tested in input/build/files/
Fil
force-pushed
the
fil/relative-file
branch
from
990fbe1
to
aeab77d
Compare
Fil
force-pushed
the
fil/relative-file
branch
from
aeab77d
to
0e3c901
Compare
Fil
commented
Nov 17, 2023
mbostock
requested changes
Nov 17, 2023
mbostock
reviewed
Nov 17, 2023
mbostock
reviewed
Nov 17, 2023
mbostock
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the _file part of #42.
I wonder if there is a cleaner way to pass the information about the relative path to
_file/subsection/; maybe by adding it as an argument to define(…). Easy to change.(This would be much simpler if we just removed the specific /_file/ path and let files be in the normal directory where they have been created. But that would be for a different PR.)