rename to “Framework”; new Getting started tutorial #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/framework
branch
from
92dac0d
to
5b9b2d8
Compare
Fil
reviewed
Jan 25, 2024
Fil
reviewed
Jan 25, 2024
Fil
reviewed
Jan 25, 2024
Co-authored-by: Philippe Rivière <fil@rezo.net>
Fil
reviewed
Jan 26, 2024
tophtucker
reviewed
Jan 31, 2024
Co-authored-by: Philippe Rivière <fil@rezo.net>
tophtucker
reviewed
Feb 1, 2024
Co-authored-by: Toph Tucker <tophtucker@gmail.com>
mythmon
reviewed
Feb 1, 2024
There was a problem hiding this comment.
The new tutorial seems like a good level of depth to me.
One issue I had while reading this is that the screenshots that include VSCode are a little hard to make sense of. I think that's mostly because I'm still using an oldschool 1x display. Maybe we could make those full width on screens with less pixels?
| <figcaption>The humble beginnings of a local weather dashboard.</figcaption> | ||
| </figure> | ||
|
|
||
| <div class="tip">The sidebar is hidden by default in narrow windows. If you don’t see the sidebar, you can show it by making the window wider, or using Command-B (⌘B) or Option-B (⌥B) on Firefox and non-macOS, or clicking the right-pointing arrow ↦ on the left edge of the window.</div> |
There was a problem hiding this comment.
For me, neither Alt-B nor Ctrl-B work in Chrome or Firefox on Linux or Windows. Super-B works in Chrome on Linux, but nowhere else. Hotkeys are hard :(
|
I increased the max-width of the figures to 960px. You can right-click and open them in a new window too, if needed, but I think that’s as good as it’ll get. |
|
The increased max width on the image helps, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This…
observable createprojectsobservable createThis does not…
These latter changes will follow later.