Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows support #944

Merged
merged 19 commits into from
Mar 2, 2024
Merged

windows support #944

merged 19 commits into from
Mar 2, 2024

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Mar 2, 2024

Fixes #90.

  • disable autocrlf
  • test on windows
  • cross-spawn
  • rimraf
  • use cross-env to run mocha
  • fix tests with posix paths
  • one less op
  • mostly posix
  • fix data loader and config tests
  • more tests
  • all tests passing

@mbostock mbostock changed the title mbostock/windows 2 windows support Mar 2, 2024
@mythmon mythmon marked this pull request as ready for review March 2, 2024 01:11
@mythmon mythmon linked an issue Mar 2, 2024 that may be closed by this pull request
@mythmon
Copy link
Contributor Author

mythmon commented Mar 2, 2024

I'm enabling auto merge on this; but it won't merge until our CI configuration change to look for the newly added CI jobs instead of the old one.

@@ -11,7 +11,9 @@ jobs:
strategy:
matrix:
version: [20, 21]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
fail-fast: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fail-fast: true (the default) means that if any CI job fails, the rest are immediately cancelled. fail-fast: false lets them all run to completion. true saves on CI time, false leads to easier debugging.

src/files.ts Outdated Show resolved Hide resolved
@mythmon mythmon disabled auto-merge March 2, 2024 01:22
@mythmon
Copy link
Contributor Author

mythmon commented Mar 2, 2024

We need to add rimraf to the template package.json's

@mbostock mbostock merged commit a3027dd into main Mar 2, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/windows-2 branch March 2, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Windows
2 participants