Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default format for arrays, objects, null, explicit undefined, and DOM nodes #214

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fil
Copy link
Collaborator

@Fil Fil commented Feb 24, 2022

closes #166 #164

(by "explicit undefined", I mean that the key is present and the value set to undefined. If the key is absent, we leave it as an empty cell.)

Capture d’écran 2022-02-24 à 15 47 43

Todo:

  • maybe it needs a unit test for circular javascript Objects?
  • add unit tests
  • fix tests (it should apply only to tables not select keys)

@Fil Fil marked this pull request as draft February 24, 2022 14:51
@Fil Fil requested review from visnup and mbostock February 25, 2022 11:38
@Fil Fil marked this pull request as ready for review February 25, 2022 11:38
@Fil Fil changed the title default format for arrays, objects, null and explicit undefined default format for arrays, objects, null, explicit undefined, and DOM nodes Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show (JSON) objects in tables?
1 participant