Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The grid scale option needs documentation & tests #1372

Closed
Fil opened this issue Mar 22, 2023 · 0 comments · Fixed by #1408
Closed

The grid scale option needs documentation & tests #1372

Fil opened this issue Mar 22, 2023 · 0 comments · Fixed by #1408
Labels
documentation Improvements or additions to docs

Comments

@Fil
Copy link
Contributor

Fil commented Mar 22, 2023

since #1197 we can pass a color string, a number, an interval… a the scale's grid option.

see ts documentation in #1371
@Fil Fil added the documentation Improvements or additions to docs label Mar 22, 2023
@mbostock mbostock changed the title the grid (scale option) options need documentation & tests The grid scale option needs documentation & tests Mar 25, 2023
Fil added a commit that referenced this issue Mar 30, 2023
@Fil
document grid: string etc.
ab6459b 
note: there are tests in aapl-close.ts.

closes #1372
@Fil Fil mentioned this issue Mar 30, 2023
Merged
mbostock added a commit that referenced this issue Mar 30, 2023
@Fil @mbostock
document grid: string etc. (#1408)
cc8ce36 
* document grid: string etc.

note: there are tests in aapl-close.ts.

closes #1372

* Update README.md

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
@Fil @mbostock @chaichontat
document grid: string etc. (observablehq#1408)
ac1f85c 
* document grid: string etc.

note: there are tests in aapl-close.ts.

closes observablehq#1372

* Update README.md

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document grid: string etc. observablehq/plot
1 participant
@Fil