Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom grid density or values. #7

Closed
mbostock opened this issue Oct 29, 2020 · 0 comments · Fixed by #1197
Closed

Custom grid density or values. #7

mbostock opened this issue Oct 29, 2020 · 0 comments · Fixed by #1197
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

Currently grid is strictly a boolean, but true could be equivalent to the corresponding ticks, a number could compute new ticks (e.g., for higher density) and an array could contain explicit tick values.
@mbostock mbostock added the enhancement New feature or request label Nov 3, 2020
Fil added a commit that referenced this issue Dec 15, 2021
@Fil
The grid option accepts a boolean (true), a positive number, and an a…
dc0cbf3 
…rray of tick values

Other changes:
* The grids are not mixed with the axis ticks any more. Instead, they are created in a g element below the axis, with a .grid className.
* The faceted grids are not generated as interrupted paths, but as groups of lines (making it easier to work with them downstream).
* The code is a few lines longer but (imho) easier to read.

closes #7
@mbostock mbostock mentioned this issue Dec 15, 2021
Closed
@Fil Fil mentioned this issue Dec 22, 2021
Open
Fil added a commit that referenced this issue Jan 11, 2022
@Fil
The grid option accepts a boolean (true), a positive number, and an a…
fcd4949 
…rray of tick values

Other changes:
* The grids are not mixed with the axis ticks any more. Instead, they are created in a g element below the axis, with a .grid className.
* The faceted grids are not generated as interrupted paths, but as groups of lines (making it easier to work with them downstream).
* The code is a few lines longer but (imho) easier to read.

closes #7
@Fil Fil mentioned this issue Jul 13, 2022
Closed
1 task
@mbostock mbostock mentioned this issue Dec 31, 2022
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@mbostock