Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show a warning for missing/invalid values in channels. #1091

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 17, 2022

For discussion, as a way to address #493 by adding a warning (#755) when some channel values are ignored.

Q: should this be opt-in or opt-out?

Capture d’écran 2022-10-17 à 16 14 59

Q: should this be opt-in or opt-out?
@Fil
Copy link
Contributor Author

Fil commented Oct 17, 2022

word-cloud.js is an example where we deliberately use an empty value (the text mark filters out "") to choose the words we display:

text: (d) => (d.length > 1 ? `${d[0]} (${d.length})` : ""),

Having to opt-out by setting ignoreMissing: true in this case would be unfortunate. Maybe we need two pass filters: first, for missing/invalid values (only checking undefined and NaN), and warning about it; second, the mark's normal filter. However this doesn't really work for the case of the dot mark which rejects negative values.

Capture d’écran 2022-10-17 à 16 21 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant