Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the quantile scale supports the unknown option #1321

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 8, 2023

fixes #1319

@Fil Fil requested a review from mbostock March 8, 2023 19:15
@Fil
Copy link
Contributor Author

Fil commented Mar 8, 2023

Optional follow-up: #1322

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

Comment on lines 5 to 10
const sample = await d3.csv("data/penguins.csv", d3.autoType).then((data) =>
data.map((d, i) => ({
...d,
body_mass_g: i % 7 === 0 ? NaN : d.body_mass_g
}))
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (await d3.csv(…)).map will be a little shorter than await d3.csv(…).then((data) => data.map(…)).

@Fil Fil merged commit cb21e4e into main Mar 9, 2023
@Fil Fil deleted the fil/quantile-unknown branch March 9, 2023 07:30
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quantile color scale doesn't respect unknown
2 participants