Auto mark: zero baseline default for rules #1341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mike writes:
Now it does!
A couple notes:
barY or areaY or rectY or… ruleX? Yes; ruleY would be the one parallel to the y baseline, and can make sense without any zero baseline; ruleX is the one orthogonal to the baseline, which has to “stand on it” (like barY).
Merely adding
|| mark === ruleY
and|| mark === ruleX
to the conditional breaks autoNullReduceContinuous and autoNullReduceDate, so I also added theX &&
andY &&
checks, which seem like a good idea anyway.The new test case demonstrates the existing issue that a rule can overhang its baseline… but that sounds like a whole can of worms and I wouldn't worry about it lol: