Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow mixed-case class names #1347

Merged
merged 2 commits into from
Mar 16, 2023
Merged

allow mixed-case class names #1347

merged 2 commits into from
Mar 16, 2023

Conversation

mbostock
Copy link
Member

Fixes #1345.

@mbostock mbostock requested a review from Fil March 16, 2023 18:49
@mbostock
Copy link
Member Author

mbostock commented Mar 16, 2023 •
edited
Loading

@Fil Can you provide a reference for the regex you added to validate class names in #582? I’d like to double-check that we can’t simplify that further.

Edit: Found it here and it looks like it can’t be simplified because of the complexity around escaping.

@Fil
Copy link
Contributor

Fil commented Mar 16, 2023

https://observablehq.com/@fil/valid-classname

re-reading the spec I think I forgot "case-insensitive"

Fil
Fil approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha that's the topic of this PR :)
I should have read the whole thing before answering your question!

@mbostock mbostock merged commit 88b536a into main Mar 16, 2023
@mbostock mbostock deleted the mbostock/valid-class-name branch March 16, 2023 19:32
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
@mbostock @chaichontat
allow mixed-case class names (observablehq#1347)
5014e6b 
* allow mixed-case class names

* more tests; cite spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validClassName doesn't like camelCase class names.
2 participants
@mbostock @Fil