propagate className option to legends #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
approved these changes
Apr 14, 2023
| @@ -141,7 +141,7 @@ export function plot(options = {}) { | |||
| const {fx, fy} = scales; | |||
| const subdimensions = fx || fy ? innerDimensions(scaleDescriptors, dimensions) : dimensions; | |||
| const superdimensions = fx || fy ? actualDimensions(scales, dimensions) : dimensions; | |||
| const context = createContext(options, subdimensions, scaleDescriptors); | |||
| const context = createContext(options, subdimensions, className); | |||
There was a problem hiding this comment.
className replaces the spurious argument scaleDescriptors in the call to createContext—this was introduced by #1197, and was ignored in the function's signature.
mbostock
force-pushed
the
mbostock/legend-class
branch
2 times, most recently
from
2121ce6
to
7bc6df1
Compare
mbostock
force-pushed
the
mbostock/legend-class
branch
from
7bc6df1
to
010eee0
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for deterministic server-side rendering of legends.