preserve group input order #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Dec 23, 2023
There was a problem hiding this comment.
This should probably use multiply blending so the appearance is not affected by order, but that makes it unacceptably slow. 😞
There was a problem hiding this comment.
we could switch to computing the end color directly? challenge unrelated to this PR though :)
Fil
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
we could switch to computing the end color directly? challenge unrelated to this PR though :)
Co-authored-by: Philippe Rivière <fil@rezo.net>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* preserve group input order * sort: "z"; fix tests * reduce z docs * fix tests * Update docs/transforms/group.md Co-authored-by: Philippe Rivière <fil@rezo.net> --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1678. If we simply don’t sort the groups naturally by key, then the groups will be in input order and hence the sort option will generally work as expected.
I’ll need to fix a number of the tests that relied on the implicit sort.Done.