Allow passing in specials via runtime.module(...)

observablehq · Oct 15, 2019 · c24a4e1 · c24a4e1
1 parent eb641cf
commit c24a4e1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/module.js b/src/module.js
@@ -6,13 +6,14 @@ import rethrow from "./rethrow";
 import {variable_invalidation, variable_visibility} from "./runtime";
 import Variable, {TYPE_DUPLICATE, TYPE_IMPLICIT, TYPE_NORMAL, no_observer} from "./variable";
 
-export default function Module(runtime) {
+export default function Module(runtime, special = {}) {
   Object.defineProperties(this, {
     _runtime: {value: runtime},
     _scope: {value: new Map},
     _special: {value: new Map([
       ["invalidation", variable_invalidation],
-      ["visibility", variable_visibility]
+      ["visibility", variable_visibility],
+      ...Object.entries(special)
     ])},
     _source: {value: null, writable: true}
   });

diff --git a/src/runtime.js b/src/runtime.js
@@ -50,7 +50,7 @@ function runtime_dispose() {
   });
 }
 
-function runtime_module(define, observer = noop) {
+function runtime_module(define, observer = noop, special = {}) {
   let module;
   if (define === undefined) {
     if (module = this._init) {
@@ -61,7 +61,7 @@ function runtime_module(define, observer = noop) {
   }
   module = this._modules.get(define);
   if (module) return module;
-  this._init = module = new Module(this);
+  this._init = module = new Module(this, special);
   this._modules.set(define, module);
   try {
     define(this, observer);

diff --git a/test/module/special-test.js b/test/module/special-test.js
@@ -1,11 +1,11 @@
 import { Runtime } from "../../src";
 import tape from "../tape";
 import valueof from "../variable/valueof";
+import noop from "../../src/noop";
 
-tape("module._special is defines an module local variable", async test => {
+tape("module._special defines a module local variable", async test => {
   const runtime = new Runtime();
-  const module = runtime.module();
-  module._special.set("foo", () => 42);
+  const module = runtime.module(noop, undefined, {foo: () => 42});
   const bar = module.variable(true).define("bar", ["foo"], foo => foo + 1);
   await new Promise(setImmediate);
   test.deepEqual(await valueof(bar), {value: 43});