Add flags for setting maximum TLS version and client authentication #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
periklis
approved these changes
Jul 7, 2022
squat
reviewed
Jul 7, 2022
| cipherSuiteIDs, err := flag.TLSCipherSuites(cipherSuites) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("TLS cipher suite name to ID conversion: %v", err) | ||
| } | ||
|
|
||
| tlsClientAuthType, err := parseClientAuthType(clientAuthType) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("can not parse TLS Client authentication policy: %w", err) |
There was a problem hiding this comment.
It seems I keep making this mistake 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently encounter an issue where the health-check of HAProxy causes a periodic error message to be printed by this service:
This is because observability-api tries to request a client-certificate from all connections by default, which fails in this case because HAProxy does not do any TLS exchange, but immediately closes the connection again.
I have also added the
max-versionsetting because it was helpful during debugging this case and looked useful for the future.This PR replaces #316 .
Refs: https://issues.redhat.com/browse/LOG-2750