Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing endpoints #350

Closed
wants to merge 1 commit into from
Closed

Conversation

jpinsonneau
Copy link

This PR add the following missing endpoints:
GET /ready
GET /metrics
GET /config
GET /services
GET /loki/api/v1/status/buildinfo

These are useful when a client need status / context of running loki

@matej-g
Copy link
Contributor

matej-g commented Jul 27, 2022

I'm not that knowledgeable about Loki to know whether this is a valid use case (so I'd defer to @periklis for final word), but it does not seem right to me to expose internal Loki information to tenants. They should not care about configuration etc., these information might be useful for Observatorium admins, but they are able to see these paths directly in Loki.

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not to expose internal endpoints of Loki through the API. Literally this exposes only endpoints against the loki query-frontend. If you need such info you should use the Loki Query Frontend HTTP service.

@jpinsonneau
Copy link
Author

Following today's discussion we are going to directly call query frontend for these endpoints

FYI this is exposed to the user as troubleshoot helper in netobserv/network-observability-console-plugin#171

Thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants