Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environments: add basic memcached manifests #136

Closed
wants to merge 1 commit into from

Conversation

squat
Copy link
Member

@squat squat commented Dec 10, 2019

This commit is a follow up to
openshift/telemeter#273.

Signed-off-by: Lucas Servén Marín lserven@gmail.com

cc @kakkoyun @brancz @metalmatze @bwplotka @aditya-konarde

This commit is a follow up to
openshift/telemeter#273.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@metalmatze
Copy link
Contributor

If we keep the Telemeter as the auth proxy around, that is running in front of Observatorium, and this is for Telemeter auth, then this memcached deployment should go there. What do you think?

@squat
Copy link
Member Author

squat commented Dec 10, 2019

Definitely not against that approach either :) we can close this and move it there. My rationalization was that it’s not a requirement of telemeter but rather an optimization of the usage, so it didn’t need to be the default. Though it could also be made optional with a jsonnet config value

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's the good question about the actual deployment place.

I like it as we plan to lean heavily on Memcached for Store GW at some point as well, so this might come handy. (:

@metalmatze
Copy link
Contributor

We discussed to move this to another repo. It's unrelated to Observatorium itself.

@squat
Copy link
Member Author

squat commented Dec 10, 2019

Closing in favor of the new commit in openshift/telemeter#273

@squat squat closed this Dec 10, 2019
@squat squat deleted the memcached branch December 10, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants