use authorize-url from Secret - attempt #2 #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorfr
requested review from
brancz and
metalmatze
and removed request for
brancz
brancz
reviewed
Feb 13, 2020
| @@ -1454,6 +1454,11 @@ objects: | |||
| valueFrom: | |||
| fieldRef: | |||
| fieldPath: metadata.name | |||
| - name: AUTHORIZE_URL | |||
There was a problem hiding this comment.
this change first needs to go into the telemeter-server jsonnet code
There was a problem hiding this comment.
i thought i did them in openshift/telemeter#288
There was a problem hiding this comment.
Yes and they were pulled in with Telemeter as dependency. So this LGTM now.
There was a problem hiding this comment.
Looks like we missed something there: openshift/telemeter#322
|
/retest |
|
@metalmatze @brancz anything i can do to push this forward? |
|
We would need to fix the CI. |
|
Closing in favor of #229 |
squat
added a commit
that referenced
this pull request
Mar 31, 2020
use authorize-url from Secret - continuation of #180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to take the authorization URL out of the template and into the telemeter-server Secret.
replaces #149