Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API and deployments dependency #9

Merged
merged 1 commit into from Sep 17, 2020
Merged

Update API and deployments dependency #9

merged 1 commit into from Sep 17, 2020

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Sep 17, 2020 •
edited

Some fixes in this PR:

  1. absorb the latest deployments dependency to have Make loki optional observatorium#342
  2. update the API to replace QueryCache with QueryFrontend
  3. remove APIQuery which is not used anymore
  4. correct default-config.libsonnet location

/assign @metalmatze @squat

squat
squat approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@squat squat merged commit d861409 into observatorium:master Sep 17, 2020
@clyang82 clyang82 deleted the api_crds branch September 17, 2020 06:39
@clyang82
Copy link
Contributor Author

Thanks @squat

This was referenced Jul 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clyang82 @squat