Remove vendoring & bump go version to 1.16 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Billett <ibillett@redhat.com>
Signed-off-by: Ian Billett <ibillett@redhat.com>
squat
previously approved these changes
Jan 10, 2022
Why isn't CI running here on GitHub? Let's hold off on merging until CI is running again |
Signed-off-by: Ian Billett <ibillett@redhat.com>
|
@squat your review velocity is something I truly admire! I don't have perms to merge - please can you do the honors? |
squat
approved these changes
Jan 10, 2022
|
💞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes vendored dependencies from the repo and bumps Go to 1.16 to match the version defined in the docker file.
I've opted for
-mod modbuild args instead ofvendorwhich seemed like the most sensible option, but happy to be told otherwise :)Integration tests passed locally.