Merge pull request #106 from LCOGT/fix/dict-key-lookup

fix hour_angle equal 0 validation bug
observatorycontrolsystem · Mar 10, 2020 · 007ef12 · 007ef12
2 parents c91eb68 + aa7d51b
commit 007ef12
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/observation_portal/observations/test/tests.py b/observation_portal/observations/test/tests.py
@@ -322,6 +322,14 @@ def test_post_observation_hour_angle_missing_required_fields(self):
         self.assertEqual(response.status_code, 400)
         self.assertIn('dec', str(response.content))
 
+    def test_post_observation_hour_angle_target_of_zero_succeeds(self):
+        good_observation = copy.deepcopy(self.observation)
+        good_observation['request']['configurations'][0]['target']['type'] = 'HOUR_ANGLE'
+        good_observation['request']['configurations'][0]['target']['hour_angle'] = 0
+        del good_observation['request']['configurations'][0]['target']['ra']
+        response = self.client.post(reverse('api:schedule-list'), data=good_observation)
+        self.assertEqual(response.status_code, 201)
+
     def test_delete_observation_leaves_request(self):
         response = self.client.post(reverse('api:schedule-list'), data=self.observation)
         self.assertEqual(response.status_code, 201)

diff --git a/observation_portal/requestgroups/target_helpers.py b/observation_portal/requestgroups/target_helpers.py
@@ -46,7 +46,7 @@ def __init__(self, target):
             'epoch', 'hour_angle'
         )
 
-        if target.get('hour_angle'):
+        if target.get('type') == 'HOUR_ANGLE':
             self.required_fields = ('hour_angle', 'dec')
         else:
             self.required_fields = ('ra', 'dec')