feat: Added pymysql.connections.Connection to engine creation if settings.USE_CLOUD_SQL. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings.USE_CLOUD_SQL. feat: Added pymysql.connections.Connection to engine creation if settings.USE_CLOUD_SQL. Includes additional updates to the core/config.py to allow Cloud MySQL connections when settings.USE_CLOUD_SQL is truthy. Includes changes to alembic/env.py to run migrations in online mode.
michealroberts
force-pushed
the
refactor/alembic/cloud-mysql
branch
from
cbf176c
to
7d617f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added pymysql.connections.Connection to engine creation if settings.USE_CLOUD_SQL.
Includes additional updates to the core/config.py to allow Cloud MySQL connections when settings.USE_CLOUD_SQL is truthy.
Includes changes to alembic/env.py to run migrations in online mode.